Large model class refactoring: Introduce ...AdapterModel
classes
#289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR performs a whole series of refactorings to...
... model classes:
modeling_X.py
modules into separate modules intransformers.adapters.models
transformers.adapters.mixins
XAdapterModel
classes as replacement forXModelWithHeads
classes to provide a clearly identified single go-to class for all adapter-related features.XModelWithHeads
classesXModelHeadsMixin
intoXAdapterModel
to simplify implementations... tests:
tests_adapters
folder. It's therefore sufficient to only run tests in this folder for CI.tests_adapters
that defines both the model test class (XAdapterModelTest
) as well as all adapter test classes (XAdapterTest
)..... documentation:
XAdapterModel
classes. All other class docs can be obtained from HFXModelWithHeads
withXAdapterModel
... misc:
__init__.py
to allow all adapter-related classes to be imported viatransformers.adapters
adding_adapters_to_a_model
guide