Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for transformer in adapter #354

Open
wants to merge 2 commits into
base: legacy
Choose a base branch
from

Conversation

amitkumarj441
Copy link

No description provided.

@calpt calpt force-pushed the master branch 2 times, most recently from 97bf6d6 to 4c34dd0 Compare May 30, 2022 16:01
@calpt
Copy link
Member

calpt commented Jun 14, 2022

Hey @amitkumarj441, thanks for working on the integration of adapters into the Transformer model, very looking forward to your contribution! To make sure the model integration is complete and working as expected, please make sure to follow our model contributing here as closely as possible. Please let us know if you need any help from our side. Thanks!

@calpt
Copy link
Member

calpt commented Sep 9, 2023

Hey, thanks again for your efforts in contributing new model architectures to adapter-transformers and sorry for the silence on our side.

In the last few weeks, we've been working on a large refactoring of our project, which will ultimately result in the release of Adapters, the next-generation adapters library. See #584.

As a consequence, we plan to merge any new model integrations directly to the new codebase, which currently can be found on this branch. Unfortunately, this necessitates some changes in the model integration code (detailed here, see already integrated models such as BERT, BART etc. for reference).

If you'd be willing to update your model integration to target the new library yourself, we'd be super happy to help you on this. Otherwise, we might look into upgrading and merging some of the open model integration PRs ourselves in the future. For more details, again see #584.

@amitkumarj441
Copy link
Author

Hey, thanks again for your efforts in contributing new model architectures to adapter-transformers and sorry for the silence on our side.

In the last few weeks, we've been working on a large refactoring of our project, which will ultimately result in the release of Adapters, the next-generation adapters library. See #584.

As a consequence, we plan to merge any new model integrations directly to the new codebase, which currently can be found on this branch. Unfortunately, this necessitates some changes in the model integration code (detailed here, see already integrated models such as BERT, BART etc. for reference).

If you'd be willing to update your model integration to target the new library yourself, we'd be super happy to help you on this. Otherwise, we might look into upgrading and merging some of the open model integration PRs ourselves in the future. For more details, again see #584.

Hi @calpt,

Thanks for letting me know about the refactoring updates.

I will have a look at the alterations in the new library and will see if I can update my existing PRs or potentially initiate new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants