Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel sequence generation with adapters #436

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

calpt
Copy link
Member

@calpt calpt commented Oct 21, 2022

Sequence generation using the model.generate() method currently doesn't support Parallel composition of adapters. This PR enables this, i.e. parallel sequence generation using different adapters using Parallel block for AdapterModel classes and adapters w. seq2seq heads.

Test: https://github.com/calpt/adapter-transformers/blob/827c627ddce5fcec1bef82e33721bcd12933fd51/tests_adapters/test_adapter_composition.py#L249-L274

@calpt calpt marked this pull request as ready for review October 24, 2022 10:21
Copy link
Member

@lenglaender lenglaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good to me

tests_adapters/test_adapter_composition.py Show resolved Hide resolved
@calpt calpt merged commit 7855c9d into adapter-hub:master Oct 27, 2022
@calpt calpt deleted the dev/parallel_seq_gen branch October 27, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants