Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Stack, Parallel & BatchSplit composition to prefix tuning #476

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Add support for Stack, Parallel & BatchSplit composition to prefix tuning #476

merged 12 commits into from
Feb 14, 2023

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 12, 2023

This PR:

  • implements Stack, Parallel & BatchSplit composition for prefix tuning modules
  • refactors the adapter composition tests to also test adapter composition using prefix tuning

@calpt
Copy link
Member Author

calpt commented Jan 16, 2023

Depends on #479.

hSterz
hSterz reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We could maybe update the documentation on composition blocks to include prefix tuning.

@calpt calpt requested a review from hSterz January 30, 2023 12:35
hSterz
hSterz approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calpt calpt mentioned this pull request Feb 14, 2023
Merged
@calpt calpt merged commit 1adc4a5 into adapter-hub:master Feb 14, 2023
@calpt calpt deleted the dev/prefix-tuning-blocks branch February 14, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz