Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adaptertrainer hyperparameter tuning #482

Merged

Conversation

dtuit
Copy link

@dtuit dtuit commented Jan 19, 2023

Prevents an error when calling Trainer.hyperparameter_search, which requires that Trainer is initialized with model set to None and model_init is used instead. Resolved by using self.model, since super().__init__ will set the value of self.model using model_init.

Prevents an error when calling Trainer.hyperparameter_search,
which requires that Trainer is initialized with model set to None
and model_init is used instead. Resolved by using self.model,
since super().__init__ will set the value of self.model using model_init.
@calpt calpt self-requested a review January 27, 2023 17:05
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing and providing a test case!

I believe this also resolves #481.

@calpt calpt linked an issue Jan 27, 2023 that may be closed by this pull request
@calpt calpt merged commit 4cd513d into adapter-hub:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdapterTrainer requires <model> even if <model_init> was provided
2 participants