Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only compute fusion reg loss if fusion layer is trained #505

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Only compute fusion reg loss if fusion layer is trained #505

merged 1 commit into from
Mar 2, 2023

Conversation

calpt
Copy link
Member

@calpt calpt commented Mar 1, 2023

Fixes #500.

@calpt calpt marked this pull request as ready for review March 2, 2023 08:47
@calpt calpt requested review from hSterz and lenglaender March 2, 2023 08:47
lenglaender
lenglaender approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@lenglaender lenglaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@calpt calpt merged commit 954d782 into adapter-hub:master Mar 2, 2023
@calpt calpt deleted the fix/adapter_trainer_fusion branch March 2, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenglaender lenglaender lenglaender approved these changes

@hSterz hSterz Awaiting requested review from hSterz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when training an adapter in a Stack[Fuse[A, B], C] composition scenario
2 participants
@calpt @lenglaender