Add adapter support for X-MOD model #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xmod class conversion Fix issues after refactoring Xmod docs & adapter-specific logic Checkpoint conversion. minor modifications
calpt
force-pushed
the
dev/adapters/xmod
branch
from
c4bc1e0
to
158f889
Compare
calpt
force-pushed
the
dev/adapters/xmod
branch
from
3465a21
to
78999aa
Compare
hSterz
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates adapter support into HuggingFace's X-MOD implementation.
Implementation notes
HF model already supports adapters integrated into X-MOD. Several changes were necessary to make HF's implementation compatible with Adapters:
lang_idsparameter andset_default_language()are deactivated in favor of regular adapter methods. Documented in model class docs.utils/convert_xmod_checkpoint.pyOnly converted checkpoints can be used with Adapters. We'll convert & re-upload some of the original X-MOD checkpoints to the Hub.Tasks