-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards Compatibility Tests #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates branch for development of backwards compatibility tests - Sets up fundamental structure
hSterz
approved these changes
Nov 1, 2023
calpt
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Could you add a short readme to the folder describing how to run the checks/ configure them?
- add first draft of a README on how to use the back_comp directory
- format files and remove unused imports
- fixes a type - rewrites passages for better readability
- adds more details to the procedure - makes clearer that `dev` and `main` are only representative for the generic concept of comparing two branches
- move backcomp directory to Utils directory - now the tests of the ci-pipeline also run for the backcomp dir
- run the commands for proper file formatting
- Add more details to the documentation of the pyhton scripts
- Add more details to the documentation of the Utils functions - Remove redundant functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Backward Compatibility Testing
Description
This Pull Request introduces backward compatibility tests to ensure that different branches produce identical model outputs under the same conditions. The primary goal of these tests is to confirm that there are no regressions or inconsistencies in the model's behavior when developing or refactoring features on a development branch based on the main branch.
Changes
compare.sh
for running backward compatibility tests.create_outputs.py
andcompare_outputs.py
, to generate and compare reference model outputs.create_outputs.py
.compare_outputs.py
.How to Use
back_comp
directory in the terminalsh compare.sh