Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync/v4.35.2 #602

Merged
merged 14 commits into from
Nov 20, 2023
Merged

Sync/v4.35.2 #602

merged 14 commits into from
Nov 20, 2023

Conversation

lenglaender
Copy link
Member

No description provided.

@lenglaender lenglaender mentioned this pull request Nov 14, 2023
Merged
@calpt calpt added the sync label Nov 14, 2023
@lenglaender lenglaender changed the base branch from adapters to main November 14, 2023 20:54
@lenglaender lenglaender marked this pull request as ready for review November 19, 2023 20:10
@lenglaender lenglaender changed the title WIP: Sync/v4.35.0 Sync/v4.35.0 Nov 19, 2023
calpt
calpt reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few questions left. Thanks for refactoring the test folder structure!

setup.py Outdated Show resolved Hide resolved
tests/tests_adapters/test_adapter_backward_compability.py Outdated Show resolved Hide resolved
@calpt calpt self-requested a review November 20, 2023 12:59
@lenglaender lenglaender merged commit 33a47b8 into adapter-hub:main Nov 20, 2023
5 checks passed
@lenglaender lenglaender changed the title Sync/v4.35.0 Sync/v4.35.2 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calpt calpt calpt approved these changes

Assignees
No one assigned
Labels
sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenglaender @calpt