Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add leave_out to LoRA / (IA)^3 #608

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add leave_out to LoRA / (IA)^3 #608

merged 2 commits into from
Dec 1, 2023

Conversation

calpt
Copy link
Member

@calpt calpt commented Nov 25, 2023

Changes multiple things related to leave_out:

  • Add config attribute for LoRA & (IA)^3
  • Fixes error when using leave_out with compacter.
  • Adds a test case for all supporting adapter methods.

@calpt
Add leave_out to LoRA / (IA)^3.
2f45b78 
Fix `leave_out` for Compacter.
Add tests for `leave_out`.
@calpt calpt changed the title Add leave_out to LoRA / (IA)^3. Add leave_out to LoRA / (IA)^3 Nov 25, 2023
@calpt calpt marked this pull request as ready for review November 25, 2023 11:01
hSterz
hSterz approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calpt calpt merged commit a290a27 into adapter-hub:main Dec 1, 2023
5 checks passed
@calpt calpt deleted the dev/leave_out branch December 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

@lenglaender lenglaender Awaiting requested review from lenglaender

@TimoImhof TimoImhof Awaiting requested review from TimoImhof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz