Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unipelt Lora default config #682

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix Unipelt Lora default config #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/method_combinations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ which is identical to the following `ConfigUnion`:
from adapters import ConfigUnion, LoRAConfig, PrefixTuningConfig, SeqBnConfig

config = ConfigUnion(
LoRAConfig(r=8, use_gating=True),
LoRAConfig(r=8, alpha=2, use_gating=True),
PrefixTuningConfig(prefix_length=10, use_gating=True),
SeqBnConfig(reduction_factor=16, use_gating=True),
)
Expand Down
2 changes: 1 addition & 1 deletion src/adapters/configuration/adapter_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ def __init__(
components = [
prefix_tuning or PrefixTuningConfig(prefix_length=10),
adapter or SeqBnConfig(reduction_factor=16),
lora or LoRAConfig(r=8),
lora or LoRAConfig(r=8, alpha=2),
]

super().__init__(*[c.replace(use_gating=True) for c in components])
Expand Down
Loading