-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLbart support #709
PLbart support #709
Conversation
Hey @FahadEbrahim, Thank you so much for working on this! We'll look into your PR more closely in the coming days. In the meantime, it would be great if you could continue to work on making the failing checks passing and let us know if you need any help on that! |
Thank you @calpt for your kind reply. The testing of the models and the methods were successful. I was having an issue with the first test of code quality. It was due to not cloning the repo recursively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished a review pass of the changes in this PR and everything looks good to me (just one minor comment)! Would be awesome to see any adapters you trained with this implementation on the hub.
After comments & merge conflicts are resolved, we're good to merge from our side. Thanks again for working on this!
Thank you @calpt for reviewing the PR. The conflict has been fixed. |
Hi,
This is a PR to add the PLBART model written in the following paper. The original code is available at the following link. It follows the BART architecture, so, I followed the same style.
This is my first PR, so apologies in advance for any errors and I'd appreciate your feedback and guidance.
Thanks,
Fahad.