Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output_embeddings get/ set for empty active head #754

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix output_embeddings get/ set for empty active head #754

merged 1 commit into from
Oct 30, 2024

Conversation

calpt
Copy link
Member

@calpt calpt commented Oct 27, 2024

Fixes #742.

@calpt calpt marked this pull request as ready for review October 27, 2024 13:13
@calpt calpt mentioned this pull request Oct 27, 2024
Closed
TimoImhof
TimoImhof approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoImhof TimoImhof merged commit 0c1039b into adapter-hub:main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof TimoImhof approved these changes

@hSterz hSterz Awaiting requested review from hSterz

@lenglaender lenglaender Awaiting requested review from lenglaender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

something wrong with delete_head implementation
2 participants
@calpt @TimoImhof