Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown on erase of existing FW #193

Closed
taylortom opened this issue Jul 19, 2023 · 1 comment
Closed

Error thrown on erase of existing FW #193

taylortom opened this issue Jul 19, 2023 · 1 comment
Assignees
@taylortom
Labels
bug question released

Comments

@taylortom
Copy link
Member

taylortom commented Jul 19, 2023 •
edited
Loading

See https://github.com/adaptlearning/adapt-cli/blob/master/lib/integration/AdaptFramework/erase.js#L25-L33.

I'm getting an ENOENT error when trying to run the install command over an existing FW (I haven't encountered this error before because the AAT purged the existing FW folder prior to running the CLI API).

This is being caused by attempts to delete files that have already been removed after their parent dir has been removed.

Some possible solutions:

  • Just call fs.remove on cwd (fs-extra version is recursive by default)
  • Glob changed to only search the first level (i.e. *)
  • Add setting nodir to ignore directories in glob results
  • Remove recursive option from fs.rm call (will also likely need glob nodir option in this case)

Your environment

  • CLI v3.0.11

Additionally, the log messages are all related to 'course', I suspect this needs to be updated..?
@taylortom taylortom self-assigned this Jul 19, 2023
@taylortom taylortom mentioned this issue Aug 7, 2023
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Aug 7, 2023
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Aug 10, 2023
github-actions bot pushed a commit that referenced this issue Aug 10, 2023
@semantic-release-bot
Chore(release): 3.1.1 [skip ci]
fabeabb 
## [3.1.1](v3.1.0...v3.1.1) (2023-08-10)

### Fix

* error thrown on recursive delete (fixes #193) (#194) ([ebc5be6](ebc5be6)), closes [#193](#193) [#194](#194)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylortom taylortom

Labels
bug question released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taylortom