Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Travis CI Build Fail #26

Merged
merged 2 commits into from
Mar 30, 2015
Merged

Conversation

himanshu1618
Copy link
Contributor

  • updated npm modules version

@oliverfoster
Copy link
Member

+1 (i don't know how to test this)

needs "slug": "^0.8.0", (was using wrong adapt-cli version)

+1 all good

  1. 'npm install -g adapt-cli' (to update adapt-cli)
  2. navigate to C:\Users[username]\AppData\Roaming\npm\node_modules\adapt-cli
  3. delete node_modules (to properly test dependencies remove all existing ones)
  4. replace package.json (with the one from PR)
  5. 'npm install' (to install defined dependencies)
  6. navigate to a test folder
  7. 'adapt create course' (to test the cli)
  8. all working

@zenduo
Copy link

zenduo commented Mar 30, 2015

+1 ditto @oliverfoster

@moloko
Copy link
Contributor

moloko commented Mar 30, 2015

Well, as it's now passing the Travis CI build, I guess we'd don't need to check it?

+1

@oliverfoster
Copy link
Member

+1 checked version bump

oliverfoster added a commit that referenced this pull request Mar 30, 2015
@oliverfoster oliverfoster merged commit 7649295 into develop Mar 30, 2015
@himanshu1618 himanshu1618 deleted the hotfix/travis_ci_build_fail_fix branch March 30, 2015 13:16
@cajones
Copy link
Contributor

cajones commented Apr 21, 2015

Hi @oliverfoster do you have an NPM login? I can add you as collaborator on the adapt-cli package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants