Fix: Removing false catchall from tests #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahirodoherty-learningpool
requested review from
oliverfoster,
ethan-lp,
joe-allen-89 and
lemmyadams
lemmyadams
approved these changes
Sep 4, 2024
|
@oliverfoster I've made an update based on your suggestion of bypassing the tests if the plugin isn't included in the build |
|
Can we do this in the task runner rather than the tests? |
|
Hmmm good point. It would be safer than having to include that before check on each test |
|
Yeahs, I know jest has a filter option. I'm not sure about cypress. If there isn't a good filter option for both, the opposite way of doing it, rather than excludes, is to only include the includes when an open (no specific file) execution is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Fix