Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_disableAccessibleState property needs documenting & adding to .schema files #190

Closed
moloko opened this issue Jan 22, 2019 · 4 comments
Closed

Comments

@moloko
Copy link
Contributor

moloko commented Jan 22, 2019

it's been added to component.model.schema (in v4) but I think it needs to be added to more than just that.

@moloko moloko changed the title _disableAccessibleState propertly needs documenting & adding to .schema files _disableAccessibleState property needs documenting & adding to .schema files Jan 22, 2019
@moloko
Copy link
Contributor Author

moloko commented May 12, 2020

as mentioned in the accessibility chat it might be of more use to drop _disableAccessibleState in favour of _isA11yComponentDescriptionEnabled (and add that to the .schema files)

@moloko
Copy link
Contributor Author

moloko commented Feb 26, 2021

as mentioned in the accessibility chat it might be of more use to drop _disableAccessibleState in favour of _isA11yComponentDescriptionEnabled (and add that to the .schema files)

Whichever we do go with, I think it would be an idea to turn off the 'heading ARIA completion' for non-interactive components like adapt-contrib-text and adapt-contrib-graphic. As these components mark as completed as soon as they are 'in view' it seems odd/confusing to tell a screenreader user that they are complete before they've actually read through them properly.

@oliverfoster oliverfoster transferred this issue from adaptlearning/adapt_framework Jul 26, 2022
@chris-steele
Copy link
Contributor

@oliverfoster if this is still required I can look at what this property means and document it

@oliverfoster
Copy link
Member

removed in #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants