Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Made headings clickable #247

Merged
merged 6 commits into from
Oct 11, 2022
Merged

Fix: Made headings clickable #247

merged 6 commits into from
Oct 11, 2022

Conversation

oliverfoster
Copy link
Member

fixes #235

Instead of using semantic heading levels, as this requires a lot of styling fixes in vanilla, I've focused more on making the headings clickable and unified, rather than having a separate heading for accessibility.

Fix

  • Unify accessible and display headings

Requires
adaptlearning/adapt-contrib-pageLevelProgress#152
adaptlearning/adapt-contrib-boxMenu#127

@oliverfoster oliverfoster self-assigned this Oct 5, 2022
@oliverfoster oliverfoster marked this pull request as ready for review October 5, 2022 11:25
This was referenced Oct 5, 2022
Merged
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the latest version of FW, Chrome and NVDA, working as expected, a very nice change for accessibility.

@oliverfoster oliverfoster merged commit 3d1e002 into master Oct 11, 2022
@oliverfoster oliverfoster deleted the issue/235 branch October 11, 2022 22:26
github-actions bot pushed a commit that referenced this pull request Oct 11, 2022
@semantic-release-bot
Chore(release): 6.20.4 [skip ci]
9f1a3c4 
## [6.20.4](v6.20.3...v6.20.4) (2022-10-11)

### Fix

* Made headings clickable (#247) ([3d1e002](3d1e002)), closes [#247](#247)
@github-actions
Copy link

🎉 This PR is included in version 6.20.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Apr 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshillen hanshillen hanshillen approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use heading elements
4 participants
@oliverfoster @hanshillen @cahirodoherty-learningpool @joe-allen-89