Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of image.jsx when rendering items has bad classNamePrefixes #478

Closed
oliverfoster opened this issue Dec 5, 2023 · 1 comment · Fixed by #479
Closed

Use of image.jsx when rendering items has bad classNamePrefixes #478

oliverfoster opened this issue Dec 5, 2023 · 1 comment · Fixed by #479
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Dec 5, 2023 •
edited
Loading

Subject of the issue

This pr into hotgraphic adaptlearning/adapt-contrib-hotgraphic#290 currently has a discrepency between the classnames in the original template and the classnames if/when using the image.jsx partial.

Currently it comes out as .hotgraphic-popup__image-container from image.jsx rather than .hotgraphic-popup__item-image-container as it is in the styling.

It should be possible to change the default classNamePrefix separator from __ to __item- in order to accommodate.
@oliverfoster oliverfoster self-assigned this Dec 5, 2023
oliverfoster added a commit that referenced this issue Dec 5, 2023
@oliverfoster
Fix: Allow classNamePrefixSeparator in image.jsx (fixes #478)
aef92ad
@oliverfoster oliverfoster mentioned this issue Dec 5, 2023
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Dec 5, 2023
joe-allen-89 pushed a commit that referenced this issue Dec 8, 2023
@oliverfoster @kirsty-hames
Fix: Allow classNamePrefixSeparator in image.jsx (fixes #478) (#479)
bf18404 
* Fix: Allow classNamePrefixSeparator in image.jsx (fixes #478)

* revert classNamePrefixSeparator being applied to attribution

---------

Co-authored-by: kirsty-hames <kirsty-hames@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Dec 8, 2023
github-actions bot pushed a commit that referenced this issue Dec 8, 2023
@semantic-release-bot
Chore(release): 6.43.2
4db5616 
## [6.43.2](v6.43.1...v6.43.2) (2023-12-08)

### Fix

* Allow classNamePrefixSeparator in image.jsx (fixes #478) (#479) ([bf18404](bf18404)), closes [#478](#478) [#479](#479) [#478](#478)
@oliverfoster
Copy link
Member Author

🎉 This issue has been resolved in version 6.43.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Allow classNamePrefixSeparator in image.jsx (fixes #478) adaptlearning/adapt-contrib-core
1 participant
@oliverfoster