Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentModel.setAttemptObject does not restore user selections #491

Closed
oliverfoster opened this issue Jan 31, 2024 · 1 comment · Fixed by #492
Closed

componentModel.setAttemptObject does not restore user selections #491

oliverfoster opened this issue Jan 31, 2024 · 1 comment · Fixed by #492
Assignees
@oliverfoster
Labels
bug Something isn't working released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jan 31, 2024 •
edited
Loading

Subject of the issue

When getting the attemptObject from a clone of a model and then updating the original with the attempt object, I would expect the user selections to be modified accordingly.

The following code does not update the original model with the cloned model selections, therefore they are not represented in the original UI:

originalModel.setAttemptObject(clonedModel.getAttemptObject());
@oliverfoster oliverfoster added the bug Something isn't working label Jan 31, 2024
@oliverfoster oliverfoster self-assigned this Jan 31, 2024
oliverfoster added a commit that referenced this issue Jan 31, 2024
@oliverfoster
Fix: Restore user answers on setAttemptObject (fixes #491)
210a929
@oliverfoster oliverfoster mentioned this issue Jan 31, 2024
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jan 31, 2024
joe-allen-89 pushed a commit that referenced this issue Feb 5, 2024
@oliverfoster
Fix: Restore user answers on setAttemptObject (fixes #491) (#492)
0359d0a
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Feb 5, 2024
github-actions bot pushed a commit that referenced this issue Feb 5, 2024
@semantic-release-bot
Chore(release): 6.45.4
0575f81 
## [6.45.4](v6.45.3...v6.45.4) (2024-02-05)

### Fix

* Restore user answers on setAttemptObject (fixes #491) (#492) ([0359d0a](0359d0a)), closes [#491](#491) [#492](#492)
@oliverfoster
Copy link
Member Author

🎉 This issue has been resolved in version 6.45.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Restore user answers on setAttemptObject (fixes #491) adaptlearning/adapt-contrib-core
1 participant
@oliverfoster