Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Auto focus next only when returning to body from disabled or hidden (fixes #486) #487

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix: Auto focus next only when returning to body from disabled or hidden (fixes #486) #487

merged 1 commit into from
Feb 2, 2024

Conversation

oliverfoster
Copy link
Member

fixes #486

Fix

  • Stop auto next focus unless focus is returning to the body from a disabled or hidden element

@oliverfoster oliverfoster added the bug Something isn't working label Jan 24, 2024
@oliverfoster oliverfoster self-assigned this Jan 24, 2024
guywillis
guywillis approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit ab127f1 into master Feb 2, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/486 branch February 2, 2024 13:25
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@semantic-release-bot
Chore(release): 6.45.1
8ccfa5c 
## [6.45.1](v6.45.0...v6.45.1) (2024-02-02)

### Fix

* Auto focus next only when returning to body from disabled or hidden (fixes #486) (#487) ([ab127f1](ab127f1)), closes [#486](#486) [#487](#487)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.45.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrowserFocus auto next errors when intentionally moving focus from hidden element
4 participants
@oliverfoster @guywillis @cahirodoherty-learningpool @lemmyadams