Fix: Call storeUserAnswer on item change (fixes #493)

[oliverfoster]

fixes #493

Fix

• Call storeUserAnswer on item change

[cahirodoherty-learningpool]

👀

[joe-allen-89]

@oliverfoster if we're firing this.storeUserAnswer on setActiveItem should we also we remove it from checkCompletionStatus as it's currently firing twice when an child's _isVisited changes?

[oliverfoster]

@oliverfoster if we're firing this.storeUserAnswer on setActiveItem should we also we remove it from checkCompletionStatus as it's currently firing twice when an child's _isVisited changes?

Hmm, probably not. One could change the active item without calling setActiveItem using the item api

adapt-contrib-core/js/models/itemModel.js

Lines 3 to 23 in 301890e

	export default class ItemModel extends LockingModel {
	defaults() {
	return {
	_isActive: false,
	_isVisited: false,
	_score: 0
	};
	}
	reset() {
	this.set({ _isActive: false, _isVisited: false });
	}
	toggleActive(isActive = !this.get('_isActive')) {
	this.set('_isActive', isActive);
	}
	toggleVisited(isVisited = !this.get('_isVisited')) {
	this.set('_isVisited', isVisited);
	}

It's a shame it's called twice. Perhaps setActiveItem in core is not the place for it? Maybe I should just move it to the narrative pr?

This is needed because checkCompletionStatus only saves before completion, not after it. With presentation components it's possible to change the active item even once the component is complete.

Or maybe it should just save whenever the children change? Detached from completion and a specific change api?

[oliverfoster]

I'm going to move this to narrative for the time being I think.

[joe-allen-89]

@oliverfoster good points I'd not thought of updating through the item, it feels like having it in core is sensible as it can be utilised by other components without duplicating.

Having it on children change does seem like a good option as it seperates it from both completion and setActiveItem, listen for change: _isActive maybe?

[oliverfoster]

_isActive and _isVisited seem to be quite closely linked, _isVisited is used for checkCompletionStatus and _isActive is used for selecting the item, with narrative something can't be _isVisited unless it was once _isActive but the code allows _isVisited and _isActive to be set independently of each other, _isVisited is used to save state here, _isActive is used to keep the active item.

I've just made it save when any property changes to keep it easy.

[oliverfoster]

🎉 This PR is included in version 6.45.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀