Fix: Resolve title/altTitle discrepancy (fixes #535)

[swashbuck]

Fixes #535

Fix

• Rework how _feedback.title and _feedback.altTitle work. _feedback.altTitle, if set, will take precedence and the feedback title will be visually hidden.
• Removes altTitle from feedbackConfig() as it did not seem to be used in the Notify templates.

The new behavior is as follows:

1. If _feedback.altTitle is set, this will be used as a title aria label. No visual title is displayed.
2. If _feedback.title is set and _feedback.altTitle is not set, a title is displayed with this value.
3. If neither _feedback.title nor _feedback.altTitle are set, a title is displayed with the component's title.
4. If none of the above are set, _globals._accessibility.altFeedbackTitle is used as an aria label and no visual title is displayed.
5. Otherwise, no title is displayed or used as an aria label

The precedence basically goes:

1. _feedback.altTitle
2. _feedback.title
3. Component title
4. _globals._accessibility.altFeedbackTitle

Related

This removes the _feedback.altTitle from the sample FW course. Otherwise, by default, the sample course does not show a feedback title due to the presence of the alt titles.
adaptlearning/adapt_framework#3567

[kirsty-hames]

This is working as described thanks 👍

[oliverfoster]

👀 this seems to make sense. I think...

If an altTitle is set in the feedback object, then only the altTitle will be used as an aria label.
If no altTitle is set in the feedback object, then the course will visually display the feedback object title or the component title or use the global altFeedbackTitle as an aria label.

[cahirodoherty-learningpool]

👀

[oliverfoster]

🎉 This PR is included in version 6.50.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀