Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Emit router:location on contentObject reload #573

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix: Emit router:location on contentObject reload #573

merged 1 commit into from
Sep 2, 2024

Conversation

oliverfoster
Copy link
Member

fixes adaptlearning/adapt-contrib-assessment#204

Fix

  • Emit router:location on contentObject reload but not on language location reset

@oliverfoster oliverfoster added the bug Something isn't working label Aug 14, 2024
@oliverfoster oliverfoster requested a review from guywillis August 14, 2024 16:32
@oliverfoster oliverfoster self-assigned this Aug 14, 2024
guywillis
guywillis approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joe-allen-89
joe-allen-89 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit f394fde into master Sep 2, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/204 branch September 2, 2024 11:05
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@semantic-release-bot
Chore(release): 6.53.8
763e097 
## [6.53.8](v6.53.7...v6.53.8) (2024-09-02)

### Fix

* Emit router:location on contentObject reload (#573) ([f394fde](f394fde)), closes [#573](#573)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.53.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assessment reset on revisit not working
4 participants
@oliverfoster @guywillis @cahirodoherty-learningpool @joe-allen-89