Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: locked attributes with conflicting default value #591

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix: locked attributes with conflicting default value #591

merged 1 commit into from
Oct 15, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Oct 14, 2024 •
edited
Loading

fixes adaptlearning/adapt-contrib-instructionError#11

This bug arose as a consequence of #585 moving _canSubmit into lockedAttributes.

Fix

  • Where model default[lockedAttributeName] is the same as lockedAttributes[lockedAttributeName] the lockingModel no longer overrides the locking value (_canSubmit question model with adapt-contrib-instructionError)
  • Invalid return early in existence check

@oliverfoster oliverfoster added the bug Something isn't working label Oct 14, 2024
@oliverfoster oliverfoster self-assigned this Oct 14, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 6c58433 into master Oct 15, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/11-instructionerror branch October 15, 2024 14:54
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
Chore(release): 6.57.2
babfed2 
## [6.57.2](v6.57.1...v6.57.2) (2024-10-15)

### Fix

* locked attributes with conflicting default value (#591) ([6c58433](6c58433)), closes [#591](#591)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.57.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No longer working?
4 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool