Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add "has-error" class for use with question components (fixes #594) #595

Merged
merged 7 commits into from
Oct 28, 2024
Merged

New: Add "has-error" class for use with question components (fixes #594) #595

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1847811
Add has-error class
swashbuck Oct 21, 2024
12bf8a9
Combine listener lines
swashbuck Oct 22, 2024
22a12c1
Merge branch 'master' into issue/594
swashbuck Oct 22, 2024
87c1eab
Move error toggle class
swashbuck Oct 22, 2024
8531816
Reorder showInstructionError lines
swashbuck Oct 22, 2024
61557b0
Remove addErrorClass
swashbuck Oct 22, 2024
a418933
Move error class assignment
swashbuck Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions js/views/questionView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ class QuestionView extends ComponentView {
}

preRender() {
// Setup listener for _isEnabled
this.listenTo(this.model, 'change:_isEnabled', this.onEnabledChanged);

this.listenTo(this.model, 'question:refresh', this.refresh);
this.listenTo(this.model, {
'change:_isEnabled': this.onEnabledChanged,
'question:refresh': this.refresh
});

// Checks to see if the question should be reset on revisit
if (this.checkIfResetOnRevisit !== QuestionView.prototype.checkIfResetOnRevisit) {
Expand Down Expand Up @@ -173,6 +173,8 @@ class QuestionView extends ComponentView {
// and give a blank method, onCannotSubmit to the question
const canSubmit = this._runModelCompatibleFunction('canSubmit');

this.model.toggleClass('has-error', !canSubmit);

if (!canSubmit) {
this.showInstructionError();
this.onCannotSubmit();
Expand Down