Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: inview reprocess on window resize (fixes #596) #597

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix: inview reprocess on window resize (fixes #596) #597

merged 1 commit into from
Oct 28, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Oct 23, 2024 •
edited
Loading

fixes #596

Inview was using old window dimensions to measure inview positions. These must be recalculated when the window is resized.

Fix

  • Trigger reprocess on window resize

@oliverfoster oliverfoster added the bug Something isn't working label Oct 23, 2024
@oliverfoster oliverfoster self-assigned this Oct 23, 2024
swashbuck
swashbuck approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 151079f into master Oct 28, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/596 branch October 28, 2024 12:38
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
Chore(release): 6.60.1
89a0421 
## [6.60.1](v6.60.0...v6.60.1) (2024-10-28)

### Fix

* inview reprocess on window resize (fixes #596) (#597) ([151079f](151079f)), closes [#596](#596) [#597](#597)
* inview return undefined when no element supplied (fixes #598) (#599) ([292a1a8](292a1a8)), closes [#598](#598) [#599](#599)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.60.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-replin joe-replin joe-replin approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working high priority released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inview on resized window doesn't trigger correctly
4 participants
@oliverfoster @swashbuck @joe-replin @cahirodoherty-learningpool