Using HTML text in handlebars fields doesn't compile properly

[robertmausser]

Subject of the issue/enhancement/features

When using html (< b >, < q > etc) in instruction text, it doesn't compile properly in the notify popup. It shows the instead of an actual quotation.

Your environment

• Adapt 5
• All browers
• All OSes

Steps to reproduce

Use any html scripting in the instruciton text area.

Expected behaviour

HTML should render properly

Actual behaviour

HTML scripting shows up in notify body text.

Screenshots (if you can)

https://snipboard.io/aZFSk4.jpg

[oliverfoster]

Curious.

adapt-contrib-instructionError/js/adapt-contrib-instructionError.js

Lines 26 to 27 in a486c90

	title: Handlebars.compile(this.config.title)(data),
	body: Handlebars.compile(this.config.body)(data)

You can see here that it does convert handlebars to html.

The example.json however is not formatted correctly at line:

adapt-contrib-instructionError/example.json

Line 5 in a486c90

"body": "{{#if instruction}}{{instruction}}{{else}}Please complete the question and then select Submit.{{/if}}"

Which should be triple curly braced:

"body": "{{#if instruction}}{{{instruction}}}{{else}}Please complete the question and then select Submit.{{/if}}"

[github-actions]

🎉 This issue has been resolved in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[oliverfoster]

did that fix it? @robertmausser