cmi.objectives issues

[oliverfoster]

Reference

Forum post: https://community.adaptlearning.org/mod/forum/discuss.php?d=4223
LMS: KnowBe4
Original pr for addition of the cmi.objectives behaviour: #280

...KnowBe4 won't let you continue if there are any errors. You can upload your package but cannot add it to any training. The support folks have been good about manually pushing it through for us, but we are going to have monthly training for the next year or so and they always need to be uploaded, viewed by others, then edited and uploaded again. With the need to contact support each time it makes this a lengthy process. That is the impact I was trying to avoid.

Issues

• No switch
  As with cmi.interactions there is a switch to enable/disable the behaviour. There is no such switch for cmi.objectives.

adapt-contrib-spoor/example.json

Line 8 in df90b8d

"_shouldRecordInteractions": true,

• Lazy objective creation
  getObjectiveById returns the next objective id if no existing id is found in the objectives list. Subsequently, the id value must be set if a new id is created or the id must be reset unnecessarily if an existing id is found as the code does not differentiate between the two scenarios. This happens after the objective index is fetched at the following lines:

adapt-contrib-spoor/js/scorm/wrapper.js

Line 704 in df90b8d

this.setValue(`${cmiPrefix}.id`, id);

adapt-contrib-spoor/js/scorm/wrapper.js

Line 713 in df90b8d

this.setValue(`${cmiPrefix}.id`, id);

adapt-contrib-spoor/js/scorm/wrapper.js

Line 730 in df90b8d

this.setValue(`${cmiPrefix}.id`, id);

The code should check for objective existence before setting the id so as not to unnecessarily reset it.

[github-actions]

🎉 This issue has been resolved in version 5.9.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀