Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question components no longer show the marking on submit #1114

Closed
RobertPeek opened this issue Jun 23, 2016 · 2 comments
Closed

Question components no longer show the marking on submit #1114

RobertPeek opened this issue Jun 23, 2016 · 2 comments

Comments

@RobertPeek
Copy link

When clicking the submit button on a question component the marking icons used to automatically show on each option. However after downloading and building the latest framework v2.0.10 this doesn't happen anymore. Was this functionality changed or is this a bug?

@moloko
Copy link
Contributor

moloko commented Jun 23, 2016

You're quite right @RobertPeek this is a bug

Confirmed that this was still working properly with Framework v2.0.9

oliverfoster added a commit that referenced this issue Jun 23, 2016
standard question view (new version) functions were not being called by the compatibility layer.

the checking statement, line 484, was checking if the required function on the current view prototype was the same as the compatibility layer function - which it always will have been because the compatibility extension view was always an extension of the question view.

i have stopped the compatibility extension including the question view prototype functions when the comparison takes place so that line 484 will not be comparing "setQuestionAsSubmitted" and "checkQuestionCompletion" to itself.
moloko added a commit that referenced this issue Jun 23, 2016
@moloko
Copy link
Contributor

moloko commented Jun 23, 2016

done in bb2396f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants