-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View Model Code to Models - Create standard models #1179
Comments
we need a core model for each
|
|
what do you envisage going into the models for those? |
Nothing, just the bog standard model. They just need to conform to the model / view separation standard. I'd like to kill off "view only" components. |
Oh right, I see - something a bit like this? return Adapt.register('blank', {
model: ComponentModel.extend({}), // Need to create a new class in the inheritance chain so that it can be extended per component type if necessary later
view: BlankView
}); |
Exactly. Then we can drop all that compatibility rubbish from QuestionView (not that it's needed for the presentation components, it will just feel a lot cleaner). |
Excellent. Would you be happy to keep the view code in adapt-contrib-blank.js - or would you want it moved to a separate .js file? |
It's fine in the main file I think. I'd prefer a separate file as an example for everyone to follow but it's really only a stylistic wish. (I updated your code example btw ^ just so that you notice) |
OK all done |
* proper transcript functionality * skip to transcript option * play, pause and ended events (as per adaptlearning/adapt_framework#2344) * configuration for player controls & fullscreen * proper use of ComponentModel (as per adaptlearning/adapt_framework#1179)
* proper transcript functionality * play, pause and ended events (as per adaptlearning/adapt_framework#2344) * configuration for player controls & fullscreen * proper use of ComponentModel (as per adaptlearning/adapt_framework#1179)
We should create a series of core component models for standard model behaviour.
The text was updated successfully, but these errors were encountered: