Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add article/block/component id as a data attribute #1380

Closed
moloko opened this issue Jan 16, 2017 · 0 comments
Closed

add article/block/component id as a data attribute #1380

moloko opened this issue Jan 16, 2017 · 0 comments
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Jan 16, 2017

The article/block/component id is already being added to the page as a class which is useful for styling but little else.

Adding this as a data attribute would make it easy to access. Something like data-adapt-id would be suitable.
@moloko moloko self-assigned this Jan 17, 2017
@moloko moloko mentioned this issue Jan 17, 2017
Merged
brian-learningpool added a commit that referenced this issue Jan 19, 2017
@brian-learningpool
Merge pull request #1381 from adaptlearning/feature/#1380
7be8269 
add a data-adapt-id attribute to the HTML for pages, menus, articles, blocks + components
moloko added a commit that referenced this issue Jul 4, 2017
@moloko
Merge pull request #1606 from adaptlearning/issue/#1380
6d3d062 
schema amends: change boolean selects to checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moloko