Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-media: toggleCaptionsButtonWhenOnlyOne #1883

Closed
danielghost opened this issue Nov 28, 2017 · 3 comments · Fixed by adaptlearning/adapt-contrib-media#188
Closed

Comments

@danielghost
Copy link
Contributor

When using "toggleCaptionsButtonWhenOnlyOne": true, it looks like the toggle functionality works (only tested on desktop), but there are issues with how the language selector appears regardless. I am guessing the issue is related to https://github.com/adaptlearning/adapt-contrib-media/blob/master/less/mep.less#L575-L577.

I haven't looked to see whether this has been fixed in the latest MediaElement or whether it is something related to our implementation of the .less, but I am pretty sure it used to work before we updated MediaElement a while back. Should we look to include another update of those files?

@moloko
Copy link
Contributor

moloko commented Dec 19, 2017

Unfortunately updating MediaElement is rarely an easy task...! Going forward we don't really need to use it any more, we mainly had it for IE8 support.

@moloko
Copy link
Contributor

moloko commented Jan 29, 2018

For the benefit of others, you can prevent the 'captions selector' popup from being displayed by adding the the following to media.less:

.mejs-captions-selector {
    display: none !important;
 }

moloko added a commit to adaptlearning/adapt-contrib-media that referenced this issue Nov 30, 2018
…nsButtonWhenOnlyOne is enabled - it doesn't update when the button is clicked and clicking the languages in it has no effect. fixes adaptlearning/adapt_framework#1883
@moloko
Copy link
Contributor

moloko commented Nov 30, 2018

@danielghost this should be fixed in adaptlearning/adapt-contrib-media#188 - could you review when you have a sec?

moloko added a commit to adaptlearning/adapt-contrib-media that referenced this issue Dec 13, 2018
and add hack to hide the captions 'language selector' popup when toggleCaptionsButtonWhenOnlyOne is enabled - it doesn't update when the button is clicked and clicking the languages in it has no effect. fixes adaptlearning/adapt_framework#1883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants