Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organise some core files to align with plugin structure #2472

Closed
oliverfoster opened this issue Jul 8, 2019 · 0 comments
Closed

Re-organise some core files to align with plugin structure #2472

oliverfoster opened this issue Jul 8, 2019 · 0 comments
Assignees
@oliverfoster
Labels
enhancement

Comments

@oliverfoster
Copy link
Member

Subject of the enhancement

src/index.html > src/core/required/index.html
src/core/js/scriptLoader.js > src/core/required/adapt/js/scriptLoader.js
src/core/js/libraries/ > src/core/libraries/

index.html and scriptLoader.js currently have their own copy entries in the grunt tasks. The can leverage the required folder pattern. The libraries folder shouldn't live in js/libraries and should instead mirror the plugin structure of pluginName/libraries as a sibling of the js folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverfoster