issue/2472 aligned core with plugin folder structure #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
requested review from
tomgreenfield,
brian-learningpool and
danielstorey
oliverfoster
changed the title
There was a problem hiding this comment.
The filter() in the copy tasks is causing the authoring tool preview to break.
This is probably due to the fact it generates includes for the config JSON.
|
thanks tom. |
|
@tomgreenfield this should be done whenever you have a moment to re-review. |
tomgreenfield
approved these changes
Jul 16, 2019
tomgreenfield
approved these changes
Jul 29, 2019
brian-learningpool
approved these changes
Aug 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2472
src/index.html>src/core/required/index.htmlsrc/core/js/scriptLoader.js>src/core/required/adapt/js/scriptLoader.jssrc/core/js/libraries/>src/core/libraries/