Adapt.wait flush #2743
Comments
|
Yes, I agree. |
danielghost
added a commit
to cgkineo/adapt-xAPI
that referenced
this issue
May 7, 2020
…cellable` attribute to error notifications to determine if the notification can be closed, or to stop Adapt from loading - requires a fix for adaptlearning/adapt_framework#2743.
danielghost
added a commit
that referenced
this issue
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is the behaviour implemented via #2439 a good idea? Isn't it the responsibility of the plugin to ensure they call an
Adapt.wait.end()if using anAdapt.wait.begin().Flushing any open waits after 7 seconds means you can't intentionally block Adapt from loading, if required. For example, you may want to not call an
end()and display an uncancellable notification to indicate an issue which should prevent a user from continuing. Currently the flush will end this, continue with the loading and eventually close any notifications regardless of the plugin functionality.The text was updated successfully, but these errors were encountered: