Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching language forces the 'start page' config to be enabled #2907

Closed
moloko opened this issue Sep 9, 2020 · 2 comments · Fixed by #2909
Closed

switching language forces the 'start page' config to be enabled #2907

moloko opened this issue Sep 9, 2020 · 2 comments · Fixed by #2909

Comments

@moloko
Copy link
Contributor

moloko commented Sep 9, 2020

If you switch language to one that has an inactive _start configuration in course.json (i.e. _start._isEnabled = false), after clicking 'yes' in the 'change language popup, the course will start in the whatever page is specified in the _start configuration.

If you completely delete the _start configuration it works as expected i.e. you are returned to the main menu for the new language.
@moloko moloko mentioned this issue Sep 9, 2020
Closed
@moloko
Copy link
Contributor Author

moloko commented Sep 9, 2020

Looks like this bug was introduced in Adapt v5.5.0 and that these lines are causing the problem...

moloko added a commit that referenced this issue Sep 9, 2020
@moloko
swap logic in ternary
f6caafb 
should only be calling getStartHash if start page is enabled
fixes #2907
@moloko moloko mentioned this issue Sep 9, 2020
Merged
@moloko
Copy link
Contributor Author

moloko commented Sep 11, 2020

just to note that this also causes problems switching language even if you don't have _start configured, see this post on the multilanguage chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug in triggerDataReady adaptlearning/adapt_framework
1 participant
@moloko