Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into hooking up jscs/jshint to travis #933

Closed
taylortom opened this issue Feb 1, 2016 · 4 comments
Closed

Look into hooking up jscs/jshint to travis #933

taylortom opened this issue Feb 1, 2016 · 4 comments

Comments

@taylortom
Copy link
Member

Support for jshint/jscs has been added here, but compliance is currently at the individual developer's discretion.

Would be nice to get this enforced in someway -- either as a git hook to be called on commit, or at the travis ci level.

I'm all for the consistency that this should bring, but think we need to be careful that we're not too strict with the rules, as will likely cause many 😠💢✊

@moloko
Copy link
Contributor

moloko commented Feb 3, 2016

yeah the danger here is that - because we are adding this after the majority of code has been written - lots of existing stuff will be flagged the first time it's run. so whoever does the first commit/push is going to be hammered with all the existing issues!

@taylortom
Copy link
Member Author

Yeah exactly. A solution could be to add a very bare-bones configuration (i.e. stuff we definitely don't want to get through like using the wrong number of spaces/tabs or whatever), and just let everything else be up to the dev.

@taylortom
Copy link
Member Author

Have set up a test. See the following for more details:

Main test consists of:

  1. jscs
  2. jshint
  3. grunt build (output suppressed on travis-ci.org)
  4. An attempted build of the updated framework against v2.0.0 core plugins

A failure during any of the above will result in an overall task failure.

Also added a webhook for integrating with gitter (linked to one of my own private chats in this test)

My tasks in script will override anything found in scripts in package.json (not currently used), not sure if this is an issue or not. I thought this way was more self-explanatory, as the entire travis test process is listed in the .travis.yml.

taylortom added a commit that referenced this issue Feb 16, 2016
`script` process executes: jscs, jshint, build, and build of the changes
against core bundle v2.0.0. Note that `script` processes defined have
been defined in `.travis.yml` rather than `package.json`. Also added a
webhook for integrating with gitter.

Fixes #933
@moloko
Copy link
Contributor

moloko commented Jun 24, 2019

see #2377

@moloko moloko closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants