-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into hooking up jscs/jshint to travis #933
Comments
yeah the danger here is that - because we are adding this after the majority of code has been written - lots of existing stuff will be flagged the first time it's run. so whoever does the first commit/push is going to be hammered with all the existing issues! |
Yeah exactly. A solution could be to add a very bare-bones configuration (i.e. stuff we definitely don't want to get through like using the wrong number of spaces/tabs or whatever), and just let everything else be up to the dev. |
Have set up a test. See the following for more details: Main test consists of:
A failure during any of the above will result in an overall task failure. Also added a webhook for integrating with gitter (linked to one of my own private chats in this test) My tasks in script will override anything found in |
`script` process executes: jscs, jshint, build, and build of the changes against core bundle v2.0.0. Note that `script` processes defined have been defined in `.travis.yml` rather than `package.json`. Also added a webhook for integrating with gitter. Fixes #933
see #2377 |
Support for jshint/jscs has been added here, but compliance is currently at the individual developer's discretion.
Would be nice to get this enforced in someway -- either as a git hook to be called on commit, or at the travis ci level.
I'm all for the consistency that this should bring, but think we need to be careful that we're not too strict with the rules, as will likely cause many 😠💢✊
The text was updated successfully, but these errors were encountered: