Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComponentView.setupInviewCompletion - use default parameters #2840

Merged
merged 1 commit into from
Jul 21, 2020
Merged

ComponentView.setupInviewCompletion - use default parameters #2840

merged 1 commit into from
Jul 21, 2020

Conversation

moloko
Copy link
Contributor

@moloko moloko commented Jul 21, 2020

resolves #2839

@moloko moloko requested a review from oliverfoster July 21, 2020 10:55
@moloko moloko changed the title use default parameters ComponentView.setupInviewCompletion - use default parameters Jul 21, 2020
tomgreenfield
tomgreenfield approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 3cfbd0d into master Jul 21, 2020
@oliverfoster oliverfoster deleted the issue/2839 branch July 21, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@jamesrea83 jamesrea83 jamesrea83 approved these changes

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

componentView.js setupInviewCompletion should make use of default parameters
5 participants
@moloko @tomgreenfield @jamesrea83 @cahirodoherty-learningpool @oliverfoster