Fix: Output the _type for items that are missing/orphaned (issue/3720) #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahirodoherty-learningpool
requested review from
ethan-lp,
lemmyadams and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where orphaned and missing items in the Language.js data helper didn't output their _type information, making it harder to identify what kind of items had issues. The change enhances error reporting by including the item type alongside the ID in error messages.
- Store
_typevalues instead of boolean flags for orphaned and missing items - Create separate arrays to track IDs while preserving type information in the original objects
- Format error messages to include both ID and type information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cahirodoherty-learningpool
moved this from New
to Needs Reviewing
in adapt_framework: The TODO Board
oliverfoster
approved these changes
Oct 6, 2025
lemmyadams
approved these changes
Oct 7, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 5.52.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3720
Fix