Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert createReactClass components to ES6 classes #1094

Merged
merged 8 commits into from
Jan 26, 2018

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Jan 25, 2018

Description

A few sentences describing the overall goals of the pull request's commits.
createReactClass module is used for components that could not be migrated to ES6 classes due to mixins. #1078 has removed mixins and the remaining components can be migrated now

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@amanmahajan7 amanmahajan7 removed the WIP label Jan 26, 2018
Copy link
Contributor

@malonecj malonecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! Thanks @amanmahajan7. Nice work

@malonecj malonecj merged commit 794b81e into master Jan 26, 2018
@amanmahajan7 amanmahajan7 deleted the am-remove-create-react-class branch January 30, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants