Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scrolling uses smooth transition effects by default #3277

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wxh16144
Copy link

@Wxh16144 Wxh16144 commented Jul 7, 2023

Great open source project, I made some changes, want to make the scrolling default with transition animation, hope you can accept my PR, thanks in advance:

like: 7.0.0-beta.30 effect

react-data-grid-srcoll-animation.mp4

@nstepien
Copy link
Contributor

nstepien commented Jul 7, 2023

Unfortunately this doesn't work well with, for example, holding down arrow keys
Recording 2023-07-07 at 11 32 36

@Wxh16144
Copy link
Author

Wxh16144 commented Jul 7, 2023

Unfortunately this doesn't work well with, for example, holding down arrow keys

I'm glad you replied, but can we consider passing the smooth transition as an option, for example, when scrollToCell is called via ref, for example

gridRef.current.scrollToCell({ idx: 123 }, { behavior: 'smooth' });

@nstepien
Copy link
Contributor

nstepien commented Jul 7, 2023

Sounds good to me

@Wxh16144 Wxh16144 force-pushed the wuxh/scroll-animation branch 2 times, most recently from c00b2ca to e94bac9 Compare July 13, 2023 09:18
@Wxh16144
Copy link
Author

I've submitted some changes, I need your help CR.

@Wxh16144 Wxh16144 force-pushed the wuxh/scroll-animation branch 2 times, most recently from dc3d5be to 59e6cee Compare July 24, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants