use Biome #3327
use Biome #3327
Conversation
| }, | ||
| "organizeImports": { | ||
| "enabled": false | ||
| } |
There was a problem hiding this comment.
Biome sorts imports on npm run check and it conflicts with prettier so turned it off. https://biomejs.dev/analyzer/#imports-sorting
should we use Biome to sort import?
There was a problem hiding this comment.
May be we can use Biome. It will be faster for sure. Let's try in a separate PR
| @@ -42,7 +42,6 @@ | |||
| }, | |||
| "complexity": { | |||
| "noExtraBooleanCast": "error", | |||
| "noExtraSemicolon": "error", | |||
There was a problem hiding this comment.
this emits error. Biome doesn't seem to have it.
and the rule seems to be removed from Rome as well
we can see that there is no page when we click the link to lint/complexity/noExtraSemicolon
from https://rome.tools/blog/2023/05/10/rome12_1/
There was a problem hiding this comment.
removed from Rome rome/tools#4576
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
- Coverage 90.49% 83.30% -7.19%
==========================================
Files 47 47
Lines 4827 4827
Branches 788 738 -50
==========================================
- Hits 4368 4021 -347
- Misses 459 806 +347 |
| }, | ||
| "organizeImports": { | ||
| "enabled": false | ||
| } |
There was a problem hiding this comment.
May be we can use Biome. It will be faster for sure. Let's try in a separate PR
* setup biome * use biome.json * turn off import sorting as it conflicts with prettier --------- Co-authored-by: Gordon Ko <gko@freewheel.com>
use Biome instead of Rome