Sourcery refactored master branch #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-221
to
+231
| attempt = try_date_expr( | ||
| if attempt := try_date_expr( | ||
| text, outputformat, extensive_search, min_date, max_date | ||
| ) | ||
| if attempt: | ||
| ): | ||
| return attempt | ||
| # try link title (Blogspot) | ||
| title_attr = trim_text(elem.get("title", "")) | ||
| if len(title_attr) > MIN_SEGMENT_LEN: | ||
| title_attr = NON_DIGITS_REGEX.sub("", title_attr[:MAX_SEGMENT_LEN]) | ||
| attempt = try_date_expr( | ||
| if attempt := try_date_expr( | ||
| title_attr, outputformat, extensive_search, min_date, max_date | ||
| ) | ||
| if attempt: | ||
| ): |
There was a problem hiding this comment.
Function examine_date_elements refactored with the following changes:
- Use named expression to simplify assignment and conditional [×2] (
use-named-expression)
Comment on lines
-407
to
+405
| year_match = yearpat.search(pattern) | ||
| if year_match: | ||
| if year_match := yearpat.search(pattern): |
There was a problem hiding this comment.
Function select_candidate refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-645
to
+642
| year = "19" + year if year[0] == "9" else "20" + year | ||
| year = f"19{year}" if year[0] == "9" else f"20{year}" |
There was a problem hiding this comment.
Function normalize_match refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-873
to
+870
| month = "0" + month | ||
| month = f"0{month}" |
There was a problem hiding this comment.
Function search_page refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| @@ -3,6 +3,7 @@ | |||
| Custom parsers and XPath expressions for date extraction | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 88-88 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-233
to
+234
| match = COMPLETE_URL.search(testurl) | ||
| if match: | ||
| if match := COMPLETE_URL.search(testurl): |
There was a problem hiding this comment.
Function extract_url_date refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| # 2. Try YYYYMMDD, use regex | ||
| match = YMD_NO_SEP_PATTERN.search(string) | ||
| if match: | ||
| if match := YMD_NO_SEP_PATTERN.search(string): |
There was a problem hiding this comment.
Function custom_parse refactored with the following changes:
- Use named expression to simplify assignment and conditional [×3] (
use-named-expression)
This removes the following comments ( why? ):
# 4. Try the Y-M and M-Y patterns
# 2. Try YYYYMMDD, use regex
# 3. Try the very common YMD, Y-M-D, and D-M-Y patterns
| match = TEXT_PATTERNS.search(htmlstring) # EN+DE+TR | ||
| if match: | ||
| if match := TEXT_PATTERNS.search(htmlstring): | ||
| parts = list(filter(None, match.groups())) | ||
| if len(parts) == 3: | ||
| candidate = None | ||
| if len(parts[0]) == 4: | ||
| candidate = datetime(int(parts[0]), int(parts[1]), int(parts[2])) | ||
| elif len(parts[2]) in (2, 4): | ||
| elif len(parts[2]) in {2, 4}: |
There was a problem hiding this comment.
Function idiosyncrasies_search refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Use set when checking membership of a collection of literals (
collection-into-set)
This removes the following comments ( why? ):
# EN+DE+TR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!