Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date attributes to HTML extraction #73

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Add date attributes to HTML extraction #73

merged 4 commits into from
Mar 13, 2023

Conversation

kernc
Copy link
Contributor

@kernc kernc commented Mar 9, 2023

As seen in, e.g.: https://www.aljazeera.com/news/2023/3/8/nato-cautious-amid-ongoing-nord-stream-blasts-investigation

Without this change, the time portion of the article is not found.

@adbar
Copy link
Owner

adbar commented Mar 9, 2023

Hi @kernc, thanks for the PR!
I just made minor adjustments, is the PR ready to merge or do you have other attributes to add?

@adbar adbar changed the title Add "publishedDate" and "lastDate" to DATE_ATTRIBUTES Add date attributes to HTML extraction Mar 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #73 (e434528) into master (5b9d47f) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files           8        8           
  Lines         942      942           
=======================================
  Hits          925      925           
  Misses         17       17           
Impacted Files Coverage Δ
htmldate/core.py 97.97% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adbar adbar merged commit b55fd2f into adbar:master Mar 13, 2023
@kernc
Copy link
Contributor Author

kernc commented Mar 13, 2023

Thanks. I was deferring while resolving some other issue while using htmldate via trafilatura (👏👏).
I don't have any others on my list at the moment, but will update when I do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants