New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish linting and quality tools #55

Open

juanjoDiaz opened this issue Feb 2, 2023 · 1 comment

Labels

question

Collaborator

juanjoDiaz commented Feb 2, 2023

We should establish how we want to lint the code.
Currently this repo includes flake8, mypy, black and pytest.
You seem to also use pylint.

We should document the agreed approach and rules in the readme and also put them in the pipeline.

adbar added the question label

Owner

adbar commented Feb 2, 2023

Yes, here are some ideas:

we could switch to mypy --strict
flake8 is used to detect obvious mistakes without starting the whole pipeline, do you have another configuration in mind?
I'm not sure how to pylint remotely, there is probably a workflow for that but I didn't take the time to check it so I'm running it locally. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment