-
Notifications
You must be signed in to change notification settings - Fork 2
chore: use pydantic for generate.toml #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The test workflow is failing in a cryptic way, I'm not sure what's up. |
|
I feel like people overuse GitHub log output grouping to make things look pretty without consideration of making the output scannable. (To be clear, the issue is pixi's setup action here) (Or really, just like GitHub expands the failing step, it should also autoexpand the last log group instead of silently hiding output) If you expand it, it says |
| ## How to Update | ||
|
|
||
| 1. Edit `workflow.py` as needed | ||
| 2. Run `adbc-gen-workflow generate-schema` to sync `generate-schema.json` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could have a pre-commit or CI step to check that this is actually in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea, I'll add it.
|
Thanks for the review. I actually rarely look at GitHub's actions output and just jump straight to the raw log output. That said, I saw the pixi error but everything I tired to fix it failed. |
|
What I tried before was to delete pixi.lock, run pixi install again, commit the new lockfile. I tried that again and still get the error. |
|
Bumping the pixi version from 0.50.2 (Jul 28, 2025) to 0.62.2 (Dec 22, 2025) seems to fix it. I made the change in a few places so we're using the same versions. Did we have a specific reason to hold the pixi version at 0.50.2? |
|
No, it's just that I haven't yet set up things to auto-update. I'll add that to the update thing... |
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Replaces the old generate.toml parsing code from a manual one to use Pydantic. This makes the code a bit easier to maintain and also gives us an easy way to generate a JSON schema for the
generate.tomlstructure that TOML LSPs like tombi can use. The latter should make it easier for driver authors to edit the file without help.Closes #44.