Skip to content

Conversation

@amoeba
Copy link
Contributor

@amoeba amoeba commented Jan 15, 2026

Replaces the old generate.toml parsing code from a manual one to use Pydantic. This makes the code a bit easier to maintain and also gives us an easy way to generate a JSON schema for the generate.toml structure that TOML LSPs like tombi can use. The latter should make it easier for driver authors to edit the file without help.

Closes #44.

@amoeba amoeba marked this pull request as ready for review January 16, 2026 21:08
@amoeba amoeba requested a review from lidavidm as a code owner January 16, 2026 21:08
@amoeba
Copy link
Contributor Author

amoeba commented Jan 16, 2026

The test workflow is failing in a cryptic way, I'm not sure what's up.

@lidavidm
Copy link
Contributor

lidavidm commented Jan 18, 2026

I feel like people overuse GitHub log output grouping to make things look pretty without consideration of making the output scannable. (To be clear, the issue is pixi's setup action here) (Or really, just like GitHub expands the failing step, it should also autoexpand the last log group instead of silently hiding output) If you expand it, it says

  /home/runner/.pixi/bin/pixi install --locked --manifest-path pyproject.toml --color always
  Error:   × lock-file not up-to-date with the workspace

## How to Update

1. Edit `workflow.py` as needed
2. Run `adbc-gen-workflow generate-schema` to sync `generate-schema.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have a pre-commit or CI step to check that this is actually in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, I'll add it.

@amoeba
Copy link
Contributor Author

amoeba commented Jan 18, 2026

Thanks for the review. I actually rarely look at GitHub's actions output and just jump straight to the raw log output. That said, I saw the pixi error but everything I tired to fix it failed.

@amoeba
Copy link
Contributor Author

amoeba commented Jan 18, 2026

What I tried before was to delete pixi.lock, run pixi install again, commit the new lockfile. I tried that again and still get the error.

@amoeba
Copy link
Contributor Author

amoeba commented Jan 18, 2026

Bumping the pixi version from 0.50.2 (Jul 28, 2025) to 0.62.2 (Dec 22, 2025) seems to fix it. I made the change in a few places so we're using the same versions. Did we have a specific reason to hold the pixi version at 0.50.2?

@lidavidm
Copy link
Contributor

No, it's just that I haven't yet set up things to auto-update. I'll add that to the update thing...

Copy link
Contributor

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 2093a04 into adbc-drivers:main Jan 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Workflow] Schema and LSP support for generate.toml

2 participants