fix: targeting keys errors in browser and product pages

[bokelley]

Summary

Fixes JavaScript errors in the targeting browser and product pages when loading targeting keys and values.

Problem 1: TypeError in targeting browser

The loadTargetingData() function was replacing the entire targetingData object with the API response:

targetingData = data;  // ❌ Replaces entire object

The API response only includes customKeys, audiences, labels, and last_sync - it doesn't include customValues. This meant that when a user clicked on a targeting key, the code tried to access targetingData.customValues[keyId], which was undefined, causing:

TypeError: undefined is not an object (evaluating 'targetingData.customValues[keyId] = data.values || []')

Problem 2: 401 errors on product pages

The targeting selector widget on product add/edit pages was making API calls without the {{ script_name }} prefix, causing 401 unauthorized errors in subdomain-based tenant routing. The dropdown would show "-- Select a key --" but wouldn't load any targeting keys.

Solutions

Fix 1: Preserve customValues cache (targeting browser)

Changed to merge the API data into existing targetingData properties instead of replacing the whole object:

// ✅ Merge properties to preserve customValues cache
targetingData.customKeys = data.customKeys || [];
targetingData.audiences = data.audiences || [];
targetingData.labels = data.labels || [];
// Don't overwrite customValues - populated on-demand by loadCustomValues()

This preserves the customValues property, which acts as a cache and gets populated on-demand when users click on targeting keys.

Fix 2: Add script_name prefix (product pages)

Added {{ script_name }} prefix to API endpoints in targeting_selector_simple.html:

// Before: /api/tenant/${tenantId}/targeting/all
// After:  {{ script_name }}/api/tenant/${tenantId}/targeting/all

This matches the pattern used in targeting_browser.html and fixes the 401 routing errors.

Test plan

• Load targeting browser page
• Verify targeting keys are displayed
• Click on a targeting key
• Verify values load successfully without TypeError
• Click on multiple keys to verify caching works
• Load product add/edit page
• Verify targeting keys dropdown loads properly
• Select a key and verify values load
• All tests pass locally (861 unit, 32 integration, 28 integration_v2)

🤖 Generated with Claude Code