Skip to content

fix: targeting keys errors in browser and product pages #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
Nov 3, 2025
Merged

fix: targeting keys errors in browser and product pages #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d897fb2
fix: preserve customValues cache when loading targeting data
bokelley Nov 3, 2025
dc34331
fix: add script_name prefix to targeting API URLs in product page
bokelley Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/components/targeting_selector_simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ <h4>🎯 Custom Targeting</h4>
document.addEventListener('DOMContentLoaded', async function() {
try {
const tenantId = '{{ tenant_id }}';
const response = await fetch(`/api/tenant/${tenantId}/targeting/all`, {
const response = await fetch(`{{ script_name }}/api/tenant/${tenantId}/targeting/all`, {
credentials: 'same-origin'
});
const data = await response.json();
Expand Down Expand Up @@ -171,7 +171,7 @@ <h4>🎯 Custom Targeting</h4>

try {
const tenantId = '{{ tenant_id }}';
const response = await fetch(`/api/tenant/${tenantId}/targeting/values/${keyId}`, {
const response = await fetch(`{{ script_name }}/api/tenant/${tenantId}/targeting/values/${keyId}`, {
credentials: 'same-origin'
});
const data = await response.json();
Expand Down
7 changes: 6 additions & 1 deletion templates/targeting_browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,12 @@ <h3>Values for Selected Key</h3>
}

const data = await response.json();
targetingData = data;

// Merge data instead of replacing to preserve customValues cache
targetingData.customKeys = data.customKeys || [];
targetingData.audiences = data.audiences || [];
targetingData.labels = data.labels || [];
// Don't overwrite customValues - it's populated on-demand by loadCustomValues()

// Update UI
updateSyncInfo(data.last_sync);
Expand Down