feat: alphabetize targeting keys/values and show display names #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the targeting selector UX by alphabetizing both keys and values, and displaying human-readable names instead of IDs in the selected targeting badges.
Changes
1. Alphabetize Targeting Keys
Added sorting after fetching keys:
2. Alphabetize Targeting Values
Added sorting after fetching values:
3. Show Display Names in Selected Targeting
Before:
iabctax: IAB20(showed IDs)After:
IAB Content: Travel(shows readable names)Implementation:
window.targetingDisplayNamesBenefits
Before/After
Dropdown Order
Before: Random order from API (Mac Support, Net for Beginners, Palmtops/PDAs, Entertainment, Visual Basic, Web Search, Travel...)
After: Alphabetical order (Entertainment, Mac Support, Net for Beginners, Palmtops/PDAs, Travel, Visual Basic, Web Search...)
Selected Display
Before:
iabctax: IAB20(ID-based)After:
IAB Content: Travel(human-readable)Test plan
🤖 Generated with Claude Code